This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement the "General" tab of new user settings #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the flair options in old settings look broken (cosmetic issues), but it's fine because we're ripping that out in due time.
This also changes the layout slightly in the user settings, but nothing detrimental.
The tab component is getting a bit hard to navigate
Also bring in the compact timeline option. Without minor CSS changes, the old user settings are completely unusable with this change. As such, minimal effort has been put in to have it be useful. Similarly, the changes drop the use of radio groups and the old theme selector was the only one that used it. See the comments for more details on how/why this was mitigated the way it was.
|
Looks like the build is angry about branches again. |
jryans
reviewed
Jan 24, 2019
| @@ -18,6 +18,7 @@ import React from "react"; | |||
| import PropTypes from 'prop-types'; | |||
| import SettingsStore from "../../../settings/SettingsStore"; | |||
| import { _t } from '../../../languageHandler'; | |||
| import ToggleSwitch from "./ToggleSwitch"; | |||
There was a problem hiding this comment.
How do we choose when to import vs. call sdk.getComponent? It seems arbitrary...
There was a problem hiding this comment.
No idea. The guideline I use is sdk.getComponent when copying old code in and import whenever I can. Usually the stuff brought in by sdk,getComponent is old and not easily import-able too.
Edit: have added it to our retro topics
There was a problem hiding this comment.
Okay, I also asked in #riot-dev as well.
|
@jryans please take another look. I've also pushed a temporary branch to riot-web for the satisfaction of green checkmarks. |
jryans
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8200
Part of element-hq/element-web#7605
This PR does a number of things to support the new tab:
DragDropContextaround the flair settings which is needed to make react not-crash. This is scheduled for removal in Redesign: Remaining bits after both user and room settings are implemented element-hq/element-web#8207.Fieldto support reading the value without controlling the inputToggleSwitchSettingsFlagover to usingToggleSwitchUserSettingshave been visibly broken but still work. Minor cosmetic fixes were done to keep it moderately usable, however it is expected that it doesn't look like what it used to.